[GitHub] [kafka] niket-goel commented on a change in pull request #10899: KAFKA-12952 Adding Delimiters to Metadata Snapshot

[GitBox]

niket-goel commented on a change in pull request #10899:
URL: https://github.com/apache/kafka/pull/10899#discussion_r658132063



##########
File path: metadata/src/test/java/org/apache/kafka/metalog/LocalLogManager.java
##########
@@ -541,6 +541,8 @@ public void resign(int epoch) {
     @Override
     public Optional<SnapshotWriter<ApiMessageAndVersion>> createSnapshot(long 
committedOffset, int committedEpoch) {
         OffsetAndEpoch snapshotId = new OffsetAndEpoch(committedOffset + 1, 
committedEpoch);
+        return SnapshotWriter.createWithHeader(
+                () -> createNewSnapshot(snapshotId),

Review comment:
       This was a miss. Let me fix it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org