jsancio commented on a change in pull request #10899:
URL: https://github.com/apache/kafka/pull/10899#discussion_r660209060
##########
File path:
clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java
##########
@@ -654,14 +657,69 @@ private static void writeLeaderChangeMessage(ByteBuffer
buffer,
long timestamp,
int leaderEpoch,
LeaderChangeMessage
leaderChangeMessage) {
+ try (MemoryRecordsBuilder builder = new MemoryRecordsBuilder(
+ buffer, RecordBatch.CURRENT_MAGIC_VALUE, CompressionType.NONE,
+ TimestampType.CREATE_TIME, initialOffset, timestamp,
+ RecordBatch.NO_PRODUCER_ID, RecordBatch.NO_PRODUCER_EPOCH,
RecordBatch.NO_SEQUENCE,
+ false, true, leaderEpoch, buffer.capacity())
+ ) {
+ builder.appendLeaderChangeMessage(timestamp, leaderChangeMessage);
+ }
+ }
+
+ public static MemoryRecords withSnapshotHeaderRecord(
+ long initialOffset,
+ long timestamp,
+ int leaderEpoch,
+ ByteBuffer buffer,
+ SnapshotHeaderRecord snapshotHeaderRecord
+ ) {
+ writeSnapshotHeaderRecord(buffer, initialOffset, timestamp,
leaderEpoch, snapshotHeaderRecord);
+ buffer.flip();
+ return MemoryRecords.readableRecords(buffer);
+ }
+
+ private static void writeSnapshotHeaderRecord(ByteBuffer buffer,
+ long initialOffset,
+ long timestamp,
+ int leaderEpoch,
+ SnapshotHeaderRecord snapshotHeaderRecord
+ ) {
+ try (MemoryRecordsBuilder builder = new MemoryRecordsBuilder(
+ buffer, RecordBatch.CURRENT_MAGIC_VALUE, CompressionType.NONE,
+ TimestampType.CREATE_TIME, initialOffset, timestamp,
+ RecordBatch.NO_PRODUCER_ID, RecordBatch.NO_PRODUCER_EPOCH,
RecordBatch.NO_SEQUENCE,
+ false, true, leaderEpoch, buffer.capacity())
+ ) {
+ builder.appendSnapshotHeaderMessage(timestamp,
snapshotHeaderRecord);
+ }
+ }
+
+ public static MemoryRecords withSnapshotFooterRecord(
+ long initialOffset,
+ long timestamp,
+ int leaderEpoch,
+ ByteBuffer buffer,
+ SnapshotFooterRecord snapshotFooterRecord
+ ) {
+ writeSnapshotFooterRecord(buffer, initialOffset, timestamp,
leaderEpoch, snapshotFooterRecord);
+ buffer.flip();
+ return MemoryRecords.readableRecords(buffer);
+ }
+
+ private static void writeSnapshotFooterRecord(ByteBuffer buffer,
+ long initialOffset,
+ long timestamp,
+ int leaderEpoch,
+ SnapshotFooterRecord snapshotFooterRecord
+ ) {
MemoryRecordsBuilder builder = new MemoryRecordsBuilder(
buffer, RecordBatch.CURRENT_MAGIC_VALUE, CompressionType.NONE,
TimestampType.CREATE_TIME, initialOffset, timestamp,
RecordBatch.NO_PRODUCER_ID, RecordBatch.NO_PRODUCER_EPOCH,
RecordBatch.NO_SEQUENCE,
false, true, leaderEpoch, buffer.capacity()
);
- builder.appendLeaderChangeMessage(timestamp, leaderChangeMessage);
+ builder.appendSnapshotFooterMessage(timestamp, snapshotFooterRecord);
builder.close();
Review comment:
We should use Java's try-with-resources here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
