[GitHub] [kafka] ccding commented on a change in pull request #10763: KAFKA-12520: Ensure log loading does not truncate producer state unless required

[GitBox]

ccding commented on a change in pull request #10763:
URL: https://github.com/apache/kafka/pull/10763#discussion_r659096284



##########
File path: core/src/main/scala/kafka/log/LogLoader.scala
##########
@@ -106,7 +158,14 @@ object LogLoader extends Logging {
       loadSegmentFiles(params)
     })
 
-    completeSwapOperations(swapFiles, params)
+    // Forth pass: rename remaining index swap files. They must be left due to 
a broker crash when

Review comment:
       Should we rename all `.swap` files in 
https://github.com/apache/kafka/pull/10763/files#diff-54b3df71b1e0697a211d23a9018a91aef773fca0b9cbd1abafbdca6c79664930R138
 no matter the file is in `toRenameSwapFiles` or not? I am not sure if we have 
to put the `retryOnOffsetOverflow` call between renaming files in 
`toRenameSwapFiles` and renaming the rest `.swap` files.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org