guozhangwang commented on a change in pull request #10917: URL: https://github.com/apache/kafka/pull/10917#discussion_r660844998
########## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ########## @@ -186,12 +190,17 @@ public void process(final K key, final V1 value) { @SuppressWarnings("unchecked") private void emitNonJoinedOuterRecords(final WindowStore<KeyAndJoinSide<K>, LeftOrRightValue> store) { + if (minTime.minTime >= maxObservedStreamTime.get() - joinAfterMs - joinBeforeMs - joinGraceMs) { Review comment: If we want to treat it as a performance/emit latency trade-off, then maybe better not piggy-back on `beforeMs` but certain value that's irrelevant to the window size? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org