spena commented on a change in pull request #10917:
URL: https://github.com/apache/kafka/pull/10917#discussion_r661715122
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java
##########
@@ -183,15 +195,27 @@ public void process(final K key, final V1 value) {
@SuppressWarnings("unchecked")
private void emitNonJoinedOuterRecords(final
WindowStore<KeyAndJoinSide<K>, LeftOrRightValue> store) {
+ if (sharedTimeTracker.minTime >= sharedTimeTracker.streamTime -
joinAfterMs - joinGraceMs) {
+ return;
+ }
+ if (context.currentSystemTimeMs() <
sharedTimeTracker.nextTimeToEmit) {
Review comment:
Btw, this won't get deterministic results, right? If I re-run the join
from the beginning, then I might get the expired records only after 50ms of my
time has passed, not by the stream time. Is that desirable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
