mumrah commented on a change in pull request #10864: URL: https://github.com/apache/kafka/pull/10864#discussion_r662517293
########## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ########## @@ -16,34 +16,41 @@ */ package kafka.raft -import java.io.File -import java.nio.file.{Files, NoSuchFileException, Path} -import java.util.{Optional, Properties} import kafka.api.ApiVersion import kafka.log.{AppendOrigin, Log, LogConfig, LogOffsetSnapshot, SnapshotGenerated} -import kafka.server.{BrokerTopicStats, FetchHighWatermark, FetchLogEnd, LogDirFailureChannel, RequestLocal} +import kafka.server.{BrokerTopicStats, FetchHighWatermark, FetchLogEnd, KafkaConfig, LogDirFailureChannel, RequestLocal} import kafka.utils.{CoreUtils, Logging, Scheduler} +import org.apache.kafka.common.config.AbstractConfig import org.apache.kafka.common.record.{MemoryRecords, Records} import org.apache.kafka.common.utils.Time import org.apache.kafka.common.{KafkaException, TopicPartition, Uuid} import org.apache.kafka.raft.{Isolation, LogAppendInfo, LogFetchInfo, LogOffsetMetadata, OffsetAndEpoch, OffsetMetadata, ReplicatedLog, ValidOffsetAndEpoch} import org.apache.kafka.snapshot.{FileRawSnapshotReader, FileRawSnapshotWriter, RawSnapshotReader, RawSnapshotWriter, SnapshotPath, Snapshots} +import java.io.File +import java.nio.file.{Files, NoSuchFileException, Path} +import java.util.{Optional, Properties} import scala.annotation.nowarn import scala.collection.mutable import scala.compat.java8.OptionConverters._ final class KafkaMetadataLog private ( - log: Log, + val log: Log, + time: Time, scheduler: Scheduler, // Access to this object needs to be synchronized because it is used by the snapshotting thread to notify the // polling thread when snapshots are created. This object is also used to store any opened snapshot reader. snapshots: mutable.TreeMap[OffsetAndEpoch, Option[FileRawSnapshotReader]], topicPartition: TopicPartition, maxFetchSizeInBytes: Int, - val fileDeleteDelayMs: Long // Visible for testing, + // Visible for testing Review comment: I'll clean this up by moving some of these into the MetadataLogConfig object -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org