cmccabe commented on a change in pull request #10995:
URL: https://github.com/apache/kafka/pull/10995#discussion_r666358707
##########
File path: tests/docker/ducker-ak
##########
@@ -185,6 +185,12 @@ must_popd() {
popd &> /dev/null || die "failed to popd"
}
+echo_and_do() {
+ local cmd="${@}"
+ echo "${cmd}"
+ ${cmd}
Review comment:
Well... I made this new function because the other one was checking the
output and exiting if it was nonzero. That didn't allow me to print the error
message I wanted. So doing the same thing here would defeat the point :)
If bash shell was a better language, I could add a lambda argument to the
existing function and have the lambda return what to print on failure. But
shell doesn't really do closures, so it would turn into kind of a mess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
