cmccabe commented on a change in pull request #10995:
URL: https://github.com/apache/kafka/pull/10995#discussion_r666362458
##########
File path: tests/docker/ducker-ak
##########
@@ -185,6 +185,12 @@ must_popd() {
popd &> /dev/null || die "failed to popd"
}
+echo_and_do() {
+ local cmd="${@}"
+ echo "${cmd}"
+ ${cmd}
Review comment:
Also I guess some people would say that I'm doing things too much the
Java way here, and that the kewl bash way of doing this would be
```
set -x
<run command>
set +x
```
But it still feels kind of like a mess since, does `set +x` change `$?` ?
Sigh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
