[GitHub] [kafka] xvrl commented on a change in pull request #11007: KAFKA-10589 Rename kafka-replica-verification CLI command line arguments for KIP-629

[GitBox]

xvrl commented on a change in pull request #11007:
URL: https://github.com/apache/kafka/pull/11007#discussion_r667359922



##########
File path: core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala
##########
@@ -89,11 +89,16 @@ object ReplicaVerificationTool extends Logging {
                          .describedAs("ms")
                          .ofType(classOf[java.lang.Integer])
                          .defaultsTo(1000)
-    val topicWhiteListOpt = parser.accepts("topic-white-list", "White list of 
topics to verify replica consistency. Defaults to all topics.")
+    val topicWhiteListOpt = parser.accepts("topic-white-list", "DEPRECATED use 
--topics-include instead; List of topics to verify replica consistency. 
Defaults to all topics.")
                          .withRequiredArg
                          .describedAs("Java regex (String)")
                          .ofType(classOf[String])
                          .defaultsTo(".*")
+    val topicIncludeOpt = parser.accepts("topics-include", "List of topics to 
verify replica consistency. Defaults to all topics.")

Review comment:
       nit, keep the variable name consistent with the argument and
   
   ```suggestion
       val topicsIncludeOpt = parser.accepts("topics-include", "List of topics 
to verify replica consistency. Defaults to all topics.")
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org