[GitHub] [kafka] xvrl commented on a change in pull request #11007: KAFKA-10589 Rename kafka-replica-verification CLI command line arguments for KIP-629

[GitBox]

xvrl commented on a change in pull request #11007:
URL: https://github.com/apache/kafka/pull/11007#discussion_r667359994



##########
File path: core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala
##########
@@ -143,11 +152,11 @@ object ReplicaVerificationTool extends Logging {
     }
 
     val filteredTopicMetadata = topicsMetadata.filter { topicMetaData =>
-      topicWhiteListFiler.isTopicAllowed(topicMetaData.name, 
excludeInternalTopics = false)
+      topicIncludeFiler.isTopicAllowed(topicMetaData.name, 
excludeInternalTopics = false)

Review comment:
       looks like there was a typo here before `s/Filter/Filter/` and also make 
topics plural for consistency
   ```suggestion
         topicsIncludeFilter.isTopicAllowed(topicMetaData.name, 
excludeInternalTopics = false)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org