mjsax commented on pull request #10953:
URL: https://github.com/apache/kafka/pull/10953#issuecomment-878687476
Correct, sliding-windows were added later and never had a default grace.
Also, we deprecated `until() / maintainMs()` before and because sliding-windows
do not inherit from `Windows<W>` is never added `until() / maintainMs()` --
thus, I don't think we need to update them. Note that there is an interplay
between grace period and retention time in the old API.
However, looking into the code of the different classes, it seems only
`TimeWindow` needs to be updated, because it implements:
```
public long maintainMs() {
return Math.max(maintainDurationMs, sizeMs + gracePeriodMs());
}
```
In contrast, `JoinWindows` used `Math.max(maintainDurationMs, size());` and
`SessionWindows` used `Math.max(maintainDurationMs, gapMs);` -- thus, there
retention-time should not be affected by any change to grace-period?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
