mjsax edited a comment on pull request #10953:
URL: https://github.com/apache/kafka/pull/10953#issuecomment-878687476
Correct, sliding-windows were added later and never had a default grace.
Also, we deprecated `until() / maintainMs()` before we added sliding-windows
and because they do not inherit from `Windows<W>` is never added `until() /
maintainMs()` -- thus, I don't think we need to update them. Note that there is
an interplay between grace period and retention time in the old API.
However, looking into the code I am a little bit confused about
`maintainMs()` in `TimeWindows`:
```
public long maintainMs() {
return Math.max(maintainDurationMs, sizeMs + gracePeriodMs());
}
```
In contrast, `JoinWindows` used `Math.max(maintainDurationMs, size());` and
`SessionWindows` used `Math.max(maintainDurationMs, gapMs);`.
Btw: yes, I believe we (technically) need to update JoinWindows, too.
However, IIRC, we never allowed to set retention time using the new API:
because for stream-stream joins, stores are not exposed via IQ, it does not
make sense to set a larger retention time than size+grace. (Ie, we ignore
`maintainMs()` / `retention()` configuration anyway).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
