kkonstantine commented on a change in pull request #8259:
URL: https://github.com/apache/kafka/pull/8259#discussion_r669042150
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
##########
@@ -48,25 +48,25 @@
import java.util.Arrays;
import java.util.Collection;
import java.util.Enumeration;
-import java.util.HashMap;
import java.util.Iterator;
import java.util.List;
-import java.util.Map;
import java.util.ServiceLoader;
import java.util.Set;
import java.util.SortedMap;
import java.util.SortedSet;
import java.util.TreeMap;
import java.util.TreeSet;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
import java.util.stream.Collectors;
public class DelegatingClassLoader extends URLClassLoader {
private static final Logger log =
LoggerFactory.getLogger(DelegatingClassLoader.class);
private static final String CLASSPATH_NAME = "classpath";
private static final String UNDEFINED_VERSION = "undefined";
- private final Map<String, SortedMap<PluginDesc<?>, ClassLoader>>
pluginLoaders;
- private final Map<String, String> aliases;
+ private final ConcurrentMap<String, SortedMap<PluginDesc<?>, ClassLoader>>
pluginLoaders;
+ private final ConcurrentMap<String, String> aliases;
Review comment:
The purpose of this change was to highlight that the data structure is
required to be concurrent.
Of course if a method that existed in `ConcurrentMap` and not in `Map` was
used, that would be a hard requirement.
`putIfAbsent` used to be such a method but that's not the case after 1.8. In
any case, the use of the more accurate interface is valid even if we don't
explicitly use methods that don't exist in the parent. That's because the need
for this implementation to be thread safe is a requirement here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
