kkonstantine commented on a change in pull request #8259:
URL: https://github.com/apache/kafka/pull/8259#discussion_r669806313
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
##########
@@ -82,11 +93,19 @@
Arrays.stream(SERVICE_LOADER_PLUGINS).map(serviceLoaderPlugin ->
MANIFEST_PREFIX + serviceLoaderPlugin.getName())
.collect(Collectors.toSet());
+ // Although this classloader does not load classes directly but rather
delegates loading to a
+ // PluginClassLoader or its parent through its base class, because of the
use of inheritance in
+ // in the latter case, this classloader needs to also be declared as
parallel capable to use
+ // fine-grain locking when loading classes.
+ static {
Review comment:
Keeping the static block here, because it's a block and that's what we
have in `PluginClassLoader`. Our style is not too strict with respect of this
ordering.
The class overwrites the `loadClass` method. But it's delegating the loading
to different classloaders and the locking is embedded in these classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
