cadonna commented on a change in pull request #10953:
URL: https://github.com/apache/kafka/pull/10953#discussion_r670352776
##########
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/JoinWindowsTest.java
##########
@@ -117,6 +118,13 @@ public void gracePeriodShouldEnforceBoundaries() {
}
}
+ @Test
+ public void oldAPIShouldSetDefaultGracePeriod() {
Review comment:
I think you also need the following test (here and in the other
`*Windows`):
```
assertThat(DEPRECATED_OLD_24_HR_GRACE_PERIOD,
is(Duration.ofDays(1).toMillis()));
```
Otherwise we will not notice if `DEPRECATED_OLD_24_HR_GRACE_PERIOD` is
changed by mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
