[GitHub] [kafka] cadonna commented on a change in pull request #10953: MINOR: Default GRACE with Old API should set as 24H minus window-size / inactivity-gap

[GitBox]

cadonna commented on a change in pull request #10953:
URL: https://github.com/apache/kafka/pull/10953#discussion_r670424591



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/kstream/JoinWindowsTest.java
##########
@@ -117,6 +118,13 @@ public void gracePeriodShouldEnforceBoundaries() {
         }
     }
 
+    @Test
+    public void oldAPIShouldSetDefaultGracePeriod() {
+        assertEquals(DEPRECATED_OLD_24_HR_GRACE_PERIOD - 3L, 
JoinWindows.of(ofMillis(3L)).gracePeriodMs());
+        assertEquals(0L, 
TimeWindows.of(ofMillis(DEPRECATED_OLD_24_HR_GRACE_PERIOD)).gracePeriodMs());
+        assertEquals(0L, 
TimeWindows.of(ofMillis(DEPRECATED_OLD_24_HR_GRACE_PERIOD + 
1L)).gracePeriodMs());

Review comment:
       ```suggestion
           assertEquals(0L, 
JoinWindows.of(ofMillis(DEPRECATED_OLD_24_HR_GRACE_PERIOD)).gracePeriodMs());
           assertEquals(0L, 
JoinWindows.of(ofMillis(DEPRECATED_OLD_24_HR_GRACE_PERIOD + 
1L)).gracePeriodMs());
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org