ijuma commented on a change in pull request #11036:
URL: https://github.com/apache/kafka/pull/11036#discussion_r671565792
##########
File path: clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java
##########
@@ -171,12 +171,24 @@
public static final String PREALLOCATE_DOC = "True if we should
preallocate the file on disk when " +
"creating a new log segment.";
+ /**
+ * @deprecated since 3.0, removal planned in 4.0. The default value for
this config is appropriate
+ * for most situations.
+ */
+ @Deprecated
public static final String MESSAGE_FORMAT_VERSION_CONFIG =
"message.format.version";
- public static final String MESSAGE_FORMAT_VERSION_DOC = "Specify the
message format version the broker " +
- "will use to append messages to the logs. The value should be a valid
ApiVersion. Some examples are: " +
- "0.8.2, 0.9.0.0, 0.10.0, check ApiVersion for more details. By setting
a particular message format " +
- "version, the user is certifying that all the existing messages on
disk are smaller or equal than the " +
- "specified version. Setting this value incorrectly will cause
consumers with older versions to break as " +
+
+ /**
+ * @deprecated since 3.0, removal planned in 4.0. The default value for
this config is appropriate
+ * for most situations.
+ */
+ @Deprecated
+ public static final String MESSAGE_FORMAT_VERSION_DOC = "[DEPRECATED]
Specify the message format version the broker " +
+ "will use to append messages to the logs if inter-broker. The value of
this config is always assumed to be `3.0` if " +
+ "`inter.broker.protocol.version` is 3.0 or higher (the actual config
value is ignored). Otherwise, the value should" +
+ "be a valid ApiVersion. Some examples are: 0.8.2, 0.9.0.0, 0.10.0,
check ApiVersion for more details. By setting a " +
Review comment:
Good point, I can fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
