ijuma commented on a change in pull request #11036:
URL: https://github.com/apache/kafka/pull/11036#discussion_r672253775
##########
File path: core/src/main/scala/kafka/log/LogManager.scala
##########
@@ -403,27 +411,49 @@ class LogManager(logDirs: Seq[File],
* Start the background threads to flush logs and do log cleanup
*/
def startup(topicNames: Set[String]): Unit = {
- startupWithConfigOverrides(fetchTopicConfigOverrides(topicNames))
+ // ensure consistency between default config and overrides
+ val defaultConfig = currentDefaultConfig
+ startupWithConfigOverrides(defaultConfig,
fetchTopicConfigOverrides(defaultConfig, topicNames))
}
// visible for testing
- private[log] def fetchTopicConfigOverrides(topicNames: Set[String]):
Map[String, LogConfig] = {
+ @nowarn("cat=deprecation")
+ private[log] def fetchTopicConfigOverrides(defaultConfig: LogConfig,
topicNames: Set[String]): Map[String, LogConfig] = {
val topicConfigOverrides = mutable.Map[String, LogConfig]()
- val defaultProps = currentDefaultConfig.originals()
+ val defaultProps = defaultConfig.originals()
topicNames.foreach { topicName =>
- val overrides = configRepository.topicConfig(topicName)
+ var overrides = configRepository.topicConfig(topicName)
Review comment:
Oh, interesting, so it does specify that a copy is returned. I had
missed that. Since the mock config repository does not implement it correctly,
as you found, I think it's better to handle this via a separate PR (it's
possible that unrelated tests may fail as a result and may need fixing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
