showuon commented on a change in pull request #11075:
URL: https://github.com/apache/kafka/pull/11075#discussion_r671805678
##########
File path: core/src/main/scala/kafka/tools/StreamsResetter.java
##########
@@ -304,7 +304,7 @@ private void parseArguments(final String[] args) {
optionParser,
options,
option,
- JavaConverters.asScalaSetConverter(invalidOptions).asScala());
+ CollectionConverters.SetHasAsScala(invalidOptions).asScala());
Review comment:
This is deprecated by scala (scala 2.12, not 0.12 :)). Here's the note
from scala doc in 2.12.0, to explain why it is deprecated:
> The transparent conversions provided here are considered fragile because
they can result in unexpected behavior and performance.
> Therefore, this API has been deprecated and JavaConverters should be used
instead.
I think that time, `CollectionConverters` haven't existed, so suggest to use
`JavaConverters` instead.
REF:
https://www.scala-lang.org/api/2.12.0/scala/collection/JavaConversions$.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
