showuon commented on a change in pull request #11075:
URL: https://github.com/apache/kafka/pull/11075#discussion_r671806614



##########
File path: core/src/main/scala/kafka/tools/StreamsResetter.java
##########
@@ -304,7 +304,7 @@ private void parseArguments(final String[] args) {
             optionParser,
             options,
             option,
-            JavaConverters.asScalaSetConverter(invalidOptions).asScala());
+            CollectionConverters.SetHasAsScala(invalidOptions).asScala());

Review comment:
       Sorry, I was wrong. Have a 2nd look, and found `CollectionConverters` 
doesn't exist in scala 2.12. So, this change will not be compatible to scala 
2.12. This change should be reverted, or maybe use `JavaConverters`? Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to