ableegoldman commented on a change in pull request #10788:
URL: https://github.com/apache/kafka/pull/10788#discussion_r683851998
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##########
@@ -1193,6 +1189,18 @@ public void updateTaskEndMetadata(final TopicPartition
topicPartition, final Lon
}
}
+ /**
+ * Checks for added or removed NamedTopologies that correspond to any
assigned tasks, and creates/freezes them if so
+ */
+ void handleTopologyUpdates() {
+ tasks.maybeCreateTasksFromNewTopologies();
+ for (final Task task : activeTaskIterable()) {
+ if
(topologyMetadata.namedTopologiesView().contains(task.id().namedTopology())) {
+ task.freezeProcessing();
Review comment:
Well long story short I was trying to avoid mucking around in the task
state management (which has historically been the source of many critical bugs)
-- also we want to remove the `suspended` state soon anyways. But actually it
seems simpler to just `close()` the tasks here and now altogether
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
