ableegoldman commented on a change in pull request #10788:
URL: https://github.com/apache/kafka/pull/10788#discussion_r683874039
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -719,6 +723,8 @@ void runOnce() {
final long pollLatency = pollPhase();
+ topologyMetadata.maybeWaitForNonEmptyTopology(() -> state);
Review comment:
Ack (although note that there's no wasted work on the restore phase
since there's by definition nothing for the thread to do yet as it won't have
been assigned any new tasks until it polls again).
I don't think it really matters much where we put this for that reason,
except for the case in which we start up with no topology -- then it's a waste
to join the group in the first place, so we may as well wait until we receive
something to work on. So yes, I'll move it back ahead of poll
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
