[GitHub] [kafka] dielhennr commented on a change in pull request #11179: KAFKA-13165: Validate node id, process role and quorum voters

[GitBox]

dielhennr commented on a change in pull request #11179:
URL: https://github.com/apache/kafka/pull/11179#discussion_r683960767



##########
File path: core/src/main/scala/kafka/raft/RaftManager.scala
##########
@@ -214,6 +220,12 @@ class KafkaRaftManager[T](
     KafkaRaftManager.createLogDirectory(new File(config.metadataLogDir), 
logDirName)
   }
 
+  // visible for testing cleanup
+  private[raft] def deleteDataDir(): Unit = {
+    val logDirName = Log.logDirName(topicPartition)
+    KafkaRaftManager.deleteLogDirectory(new File(config.metadataLogDir), 
logDirName)

Review comment:
       @jsancio What do you think about exposing this api to the package for 
cleaning up log directories in tests? I'm not sure exactly how to override 
`createDataDir` with `tempDir` from the tests. It is called internally in 
`KafkaRaftManager` without an argument.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org