hachikuji commented on a change in pull request #11225:
URL: https://github.com/apache/kafka/pull/11225#discussion_r691706079
##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -1436,17 +1438,15 @@ class ReplicaManager(val config: KafkaConfig,
leaderAndIsrRequest.partitionStates.forEach { partitionState =>
Review comment:
This logic is a bit strange. It sounds like we are trying to handle the
case where we fail to create the log after we have already created the
partition. Would it make more sense to handle this in `getOrCreatePartition` if
an exception is raised?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
