dajac commented on a change in pull request #11225:
URL: https://github.com/apache/kafka/pull/11225#discussion_r693979039



##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -1436,17 +1438,15 @@ class ReplicaManager(val config: KafkaConfig,
 
           leaderAndIsrRequest.partitionStates.forEach { partitionState =>

Review comment:
       @hachikuji @showuon I have refactored this part. I think that we could 
remove this check and replace it by making the partition offline when an 
`KafkaStorageException` occurs. Does it make sense?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to