[
https://issues.apache.org/jira/browse/KAFKA-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402624#comment-17402624
]
Tomer Wizman commented on KAFKA-12766:
--------------------------------------
Hi Bruno, Sophie, Konstantine, nice e-meeting you :)
According to the discussion here, the link Bruno attached and from what I saw
in the code is that we explicitly disable WAL, so it doesn't really matter in
terms of correctness whether we set the underlying Options object inside the
adapter class or not.
Choosing not to set it, getting null/empty value by calling the getters
afterwards might seems a bit unexpected from user perspective.
Let me know what you think (I will add warning messages to the log anyway)
BTW this is my first task in Kafka Streams (and in open source projects in
general), so any feedback is welcome!
> Consider Disabling WAL-related Options in RocksDB
> -------------------------------------------------
>
> Key: KAFKA-12766
> URL: https://issues.apache.org/jira/browse/KAFKA-12766
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Reporter: Bruno Cadonna
> Assignee: Tomer Wizman
> Priority: Minor
> Labels: newbie, newbie++
> Fix For: 3.1.0
>
>
> Streams disables the write-ahead log (WAL) provided by RocksDB since it
> replicates the data in changelog topics. Hence, it does not make much sense
> to set WAL-related configs for RocksDB instances within Streams.
> Streams could:
> - disable WAL-related options
> - ignore WAL-related options
> - throw an exception when a WAL-related option is set.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
