hachikuji commented on a change in pull request #11266:
URL: https://github.com/apache/kafka/pull/11266#discussion_r696830865
##########
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##########
@@ -2345,14 +2345,14 @@ class KafkaController(val config: KafkaConfig,
partitionResponses(partition) = Right(updatedIsr)
Some(partition -> updatedIsr)
case Left(error) =>
- warn(s"Failed to update ISR for partition $partition", error)
+ this.error(s"Failed to update ISR for partition $partition",
error)
partitionResponses(partition) = Left(Errors.forException(error))
None
}
}
badVersionUpdates.foreach(partition => {
- debug(s"Failed to update ISR for partition $partition, bad ZK version")
+ info(s"Failed to update ISR to ${adjustedIsrs(partition)} for
partition $partition, bad ZK version.")
Review comment:
nit: while we're in here, maybe we can update the loop with the more
conventional pattern:
```scala
badVersionUpdates.foreach { partition =>
```
##########
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##########
@@ -2345,14 +2345,14 @@ class KafkaController(val config: KafkaConfig,
partitionResponses(partition) = Right(updatedIsr)
Some(partition -> updatedIsr)
case Left(error) =>
- warn(s"Failed to update ISR for partition $partition", error)
+ this.error(s"Failed to update ISR for partition $partition",
error)
Review comment:
nit: maybe we could rename the variable to `err` and drop the `this.`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
