hachikuji commented on a change in pull request #11266:
URL: https://github.com/apache/kafka/pull/11266#discussion_r696875779
##########
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##########
@@ -2344,17 +2344,17 @@ class KafkaController(val config: KafkaConfig,
debug(s"ISR for partition $partition updated to
[${updatedIsr.isr.mkString(",")}] and zkVersion updated to
[${updatedIsr.zkVersion}]")
partitionResponses(partition) = Right(updatedIsr)
Some(partition -> updatedIsr)
- case Left(error) =>
- warn(s"Failed to update ISR for partition $partition", error)
- partitionResponses(partition) = Left(Errors.forException(error))
+ case Left(err) =>
Review comment:
nit: I didn't realize this was an exception on first review. How about
just `e`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
