satishd commented on a change in pull request #11058: URL: https://github.com/apache/kafka/pull/11058#discussion_r711987288
########## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemotePartitionMetadataStore.java ########## @@ -91,6 +109,23 @@ public void handleRemotePartitionDeleteMetadata(RemotePartitionDeleteMetadata re } } + @Override + public void syncLogMetadataDataFile(TopicIdPartition topicIdPartition, + int metadataPartition, + Long metadataPartitionOffset) throws IOException { + //todo-tier write partitions + RemotePartitionDeleteMetadata partitionDeleteMetadata = idToPartitionDeleteMetadata.get(topicIdPartition); + if (partitionDeleteMetadata != null) { + log.info("Skipping syncing of metadata snapshot as remote partition [{}] is with state: [{}] ", topicIdPartition, + partitionDeleteMetadata); + } else { Review comment: RemotePartitionRemover may have the functionality of removing in a different way and revisit that when we have the RemotePartitionRemover functionality. For now, the cache is stored as part of the topic partition log directory and it will be deleted when the respective partition is deleted locally by a broker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org