satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r711990585



##########
File path: 
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemotePartitionMetadataStore.java
##########
@@ -91,6 +109,23 @@ public void 
handleRemotePartitionDeleteMetadata(RemotePartitionDeleteMetadata re
         }
     }
 
+    @Override
+    public void syncLogMetadataDataFile(TopicIdPartition topicIdPartition,
+                                        int metadataPartition,
+                                        Long metadataPartitionOffset) throws 
IOException {
+        //todo-tier write partitions

Review comment:
       This todo is not valid. It is already addressed in the existing code as 
`remoteLogMetadataCache.flushToFile(metadataPartition, 
metadataPartitionOffset);`. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to