kowshik commented on a change in pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#discussion_r719800036
##########
File path: core/src/main/scala/kafka/log/LogSegment.scala
##########
@@ -77,8 +77,9 @@ class LogSegment private[log] (val log: FileRecords,
timeIndex.resize(size)
}
- def sanityCheck(timeIndexFileNewlyCreated: Boolean): Unit = {
- if (lazyOffsetIndex.file.exists) {
+ def sanityCheck(timeIndexFileNewlyCreated: Boolean, isActiveSegment:
Boolean): Unit = {
+ // We allow for absence of offset index file only for an empty active
segment.
+ if ((isActiveSegment && size == 0) || lazyOffsetIndex.file.exists) {
Review comment:
@ccding When we roll a segment, we explicitly ensure to flush only the
old segment. See [this
LOC](https://github.com/apache/kafka/blob/c6aeb5c5546f34276879c1eef4199d208f1c23dc/core/src/main/scala/kafka/log/UnifiedLog.scala#L1501).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
