RivenSun2 commented on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-942212161
@guozhangwang To add, I think it is necessary to automatically clean up non-existent offsets in the `onJoinPrepare` method We now agree that offsetCommitTimer can be the pollTimer passed by the customer. But if the customer calls `poll(final long timeoutMs)`, the situation will be worse, and `time.timer(Long.MAX_VALUE)` will replace pollTimer. ` if (includeMetadataInTimeout) { // try to update assignment metadata BUT do not need to block on the timer for join group updateAssignmentMetadataIfNeeded(timer, false); } else { while (!updateAssignmentMetadataIfNeeded(time.timer(Long.MAX_VALUE), true)) { log.warn("Still waiting for metadata"); } }` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org