RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r727950795
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##########
@@ -994,11 +996,16 @@ public boolean commitOffsetsSync(Map<TopicPartition,
OffsetAndMetadata> offsets,
if (offsets.isEmpty())
return true;
+ boolean shouldCleanUpConsumedOffsets =
!checkConsumedOffsetsAreValid(offsets);
Review comment:
change its signature as ensureActiveGroup(timer, waitOnMetadata)
I think if you pass `waitOnMetadata` to `ensureActiveGroup`, it will make
things more complicated, because
`waitOnMetadata? timer: time.timer(0L)` will need be executed multiple times
in `ensureCoordinatorReady` and `joinGroupIfNeeded`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
