vamossagar12 commented on pull request #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-951097076
> Did not look into this PR. Left the following comment on the JIRA: > > > I just got a report, that `InMemoryWindowStore` does not enforce strict retention for IQ if caching is enabled. We should add corresponding tests before we close this ticket, to ensure that caching does not break strict retention time. > > Can we address this in this PR? Based on the PR description we move the check into the metered store, and thus it should fix IQ (and thus the caching issue)? Sure @mjsax , I would include it as part of the PR. I think I am already handling it for Persistent stores so I can extend it. Having said that, there have been discussions on this PR that would be worthwhile to move the enforcement down to the individual persistent stores as this implementation of mine seems to have added some complexity. Would like to know your thoughts on this whenever you get a chance to look at the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
