RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r742560295
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##########
@@ -1073,6 +1086,33 @@ private void doAutoCommitOffsetsAsync() {
});
}
+ private boolean maybeAutoCommitOffsetsAsync() {
+ if (autoCommitEnabled) {
+ invokeCompletedOffsetCommitCallbacks();
+
+ if (onJoinPrepareAsyncCommitFuture == null)
+ onJoinPrepareAsyncCommitFuture = doAutoCommitOffsetsAsync();
+ if (onJoinPrepareAsyncCommitFuture == null)
+ return true;
+
+ client.pollNoWakeup();
+ invokeCompletedOffsetCommitCallbacks();
+
+ if (!onJoinPrepareAsyncCommitFuture.isDone())
+ return false;
+ if (onJoinPrepareAsyncCommitFuture.succeeded()) {
+ onJoinPrepareAsyncCommitFuture = null;
+ return true;
+ }
+ if (onJoinPrepareAsyncCommitFuture.failed() &&
!onJoinPrepareAsyncCommitFuture.isRetriable())
Review comment:
I agree with your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
