RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r742569946
##########
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java
##########
@@ -1053,6 +1058,49 @@ public void
testForceMetadataRefreshForPatternSubscriptionDuringRebalance() {
assertFalse(coordinator.rejoinNeededOrPending());
}
+ @Test
+ public void testForceMetadataDeleteForPatternSubscriptionDuringRebalance()
{
Review comment:
In fact, only onJoinPrepare called the maybeAutoCommitOffsetsAsync
method before.
Follow guozhang's suggestion , I will delete the
maybeAutoCommitOffsetsSync(timer) method,
close() also calls maybeAutoCommitOffsetsAsync
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
