dongjinleekr commented on a change in pull request #11474:
URL: https://github.com/apache/kafka/pull/11474#discussion_r745086781
##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -894,9 +894,11 @@ class ReplicaManager(val config: KafkaConfig,
requiredAcks: Short,
requestLocal: RequestLocal):
Map[TopicPartition, LogAppendResult] = {
val traceEnabled = isTraceEnabled
+ val failedTopicSet = mutable.Set[String]()
def processFailedRecord(topicPartition: TopicPartition, t: Throwable) = {
val logStartOffset =
onlinePartition(topicPartition).map(_.logStartOffset).getOrElse(-1L)
-
brokerTopicStats.topicStats(topicPartition.topic).failedProduceRequestRate.mark()
+ // Every time appending to a local log fails, collect the topic names
into the set.
+ failedTopicSet.add(topicPartition.topic)
brokerTopicStats.allTopicsStats.failedProduceRequestRate.mark()
Review comment:
(After some thinking) Oh, you are right. I omitted them. :sweat:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
