splett2 commented on a change in pull request #11474:
URL: https://github.com/apache/kafka/pull/11474#discussion_r745132675
##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -953,6 +957,16 @@ class ReplicaManager(val config: KafkaConfig,
}
}
}
+
+ requestedTopicSet.foreach { case topic =>
+ brokerTopicStats.topicStats(topic).totalProduceRequestRate.mark()
+ }
Review comment:
this is a good point. In that case it may be fine to keep the update
code as is. Maybe change:
`case topic =>` to just `topic =>` as i dont think the case is necessary for
iterating over a set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
