showuon commented on a change in pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#discussion_r751200340
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##########
@@ -755,18 +755,17 @@ protected void onJoinPrepare(int generation, String
memberId) {
@Override
public void onLeavePrepare() {
- // Save the current Generation and use that to get the memberId, as
the hb thread can change it at any time
+ // Save the current Generation, as the hb thread can change it at any
time
final Generation currentGeneration = generation();
- final String memberId = currentGeneration.memberId;
- log.debug("Executing onLeavePrepare with generation {} and memberId
{}", currentGeneration, memberId);
Review comment:
It's because the `memberId` info is already included in the `generation`
info. This is the log output currently:
`Executing onLeavePrepare with generation Generation{generationId=1,
memberId='consumer1', protocol='range'} and memberId consumer1`
Sorry, I should have mentioned it to make it clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
