functioner commented on a change in pull request #11504:
URL: https://github.com/apache/kafka/pull/11504#discussion_r754464724
##########
File path: core/src/test/scala/unit/kafka/network/SocketServerTest.scala
##########
@@ -867,6 +868,39 @@ class SocketServerTest {
}
}
+ @Test
+ def testExceptionInAcceptor(): Unit = {
+ val overrideNum = server.config.maxConnectionsPerIp + 1
+ val overrideProps = TestUtils.createBrokerConfig(0,
TestUtils.MockZkConnect, port = 0)
+ overrideProps.put(KafkaConfig.MaxConnectionsPerIpOverridesProp,
s"localhost:$overrideNum")
Review comment:
We need the `overrideProps` to create the `overrideServer`. From the
other tests, I didn't figure out what could be a better configuration, so I
just use the configuration in `testMaxConnectionsPerIpOverrides`. Or maybe we
can try the configuration in `testConnectionRatePerIp`. Do you have any
suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
