functioner commented on a change in pull request #11504:
URL: https://github.com/apache/kafka/pull/11504#discussion_r754482445
##########
File path: core/src/test/scala/unit/kafka/network/SocketServerTest.scala
##########
@@ -867,6 +868,39 @@ class SocketServerTest {
}
}
+ @Test
+ def testExceptionInAcceptor(): Unit = {
+ val overrideNum = server.config.maxConnectionsPerIp + 1
+ val overrideProps = TestUtils.createBrokerConfig(0,
TestUtils.MockZkConnect, port = 0)
+ overrideProps.put(KafkaConfig.MaxConnectionsPerIpOverridesProp,
s"localhost:$overrideNum")
+ val serverMetrics = new Metrics()
+
+ val overrideServer = new
SocketServer(KafkaConfig.fromProps(overrideProps), serverMetrics,
+ Time.SYSTEM, credentialProvider, apiVersionManager) {
+
+ // same as SocketServer.createAcceptor,
+ // except the Acceptor overriding a method to inject the exception
+ override protected def createAcceptor(endPoint: EndPoint, metricPrefix:
String): Acceptor = {
+ val sendBufferSize = config.socketSendBufferBytes
+ val recvBufferSize = config.socketReceiveBufferBytes
+ new Acceptor(endPoint, sendBufferSize, recvBufferSize, nodeId,
connectionQuotas, metricPrefix, time) {
+ override protected def configureAcceptedSocketChannel(socketChannel:
SocketChannel): Unit = {
+ throw new IOException("test injected IOException")
+ }
+ }
+ }
+ }
+
+ try {
+ overrideServer.startup()
+ val conn = connect(overrideServer)
+ conn.setSoTimeout(3000)
+ assertEquals(-1, conn.getInputStream.read())
Review comment:
Right. I've pushed a commit. I check if the quota is 1 after the accept,
and if the quota is 0 after the exception thrown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
