mjsax commented on a change in pull request #11455:
URL: https://github.com/apache/kafka/pull/11455#discussion_r754759809
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/GlobalKTableIntegrationTest.java
##########
@@ -337,7 +341,18 @@ public void shouldGetToRunningWithOnlyGlobalTopology()
throws Exception {
startStreams();
waitForApplicationState(singletonList(kafkaStreams), State.RUNNING,
Duration.ofSeconds(30));
- kafkaStreams.close();
Review comment:
I am personally still not sure if we actually want/need this change in
the test...
It's also somewhat incomplete, as it does not cover the initialization
phase, not do we actually process data in this test and thus don't really hit
the actual runtime path.
Last, if we test for the absence of the log of a clean shutdown, it seem we
should also test for their presents in case of an error. But testing logging
seems to get out of hand this way.
Overall, I would still be a favor to not apply this change to the tests as
it seems pointless (and potentially confusing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
