mjsax commented on a change in pull request #11455:
URL: https://github.com/apache/kafka/pull/11455#discussion_r791324669
##########
File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java
##########
@@ -459,12 +462,15 @@ public void
shouldCleanupResourcesOnCloseWithoutPreviousStart() throws Exception
final StreamsBuilder builder = getBuilderWithSource();
builder.globalTable("anyTopic");
- try (final KafkaStreams streams = new KafkaStreams(builder.build(),
props, supplier, time)) {
+ try (final LogCaptureAppender appender =
LogCaptureAppender.createAndRegister(KafkaStreams.class);
+ final KafkaStreams streams = new KafkaStreams(builder.build(),
props, supplier, time)) {
streams.close();
waitForCondition(
() -> streams.state() == KafkaStreams.State.NOT_RUNNING,
"Streams never stopped.");
+
+ assertThat(appender.getMessages(),
not(hasItem(containsString("ERROR"))));
Review comment:
Verify that a clean close does not log an error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
