vvcephei commented on a change in pull request #11582:
URL: https://github.com/apache/kafka/pull/11582#discussion_r771530728
##########
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java
##########
@@ -42,16 +102,21 @@ private StoreQueryUtils() {
final int partition
) {
- final QueryResult<R> result;
final long start = collectExecutionInfo ? System.nanoTime() : -1L;
- if (query instanceof PingQuery) {
- if (!isPermitted(position, positionBound, partition)) {
- result = QueryResult.notUpToBound(position, positionBound,
partition);
- } else {
- result = (QueryResult<R>) QueryResult.forResult(true);
- }
- } else {
+ final QueryResult<R> result;
+
+ final QueryHandler handler = QUERY_HANDLER_MAP.get(query.getClass());
Review comment:
Yep, that's accurate, but many of the stores will have the exact same
logic as each other, so it made sense to consolidate it, which is what this
util class is for.
The function in the query map just checks the type of the store so that it
can either cast it to execute the query or return "unknown query". That way, we
can use the same dispatch map for all queries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
