mjsax commented on a change in pull request #11582:
URL: https://github.com/apache/kafka/pull/11582#discussion_r771733023
##########
File path: streams/src/main/java/org/apache/kafka/streams/query/QueryResult.java
##########
@@ -197,6 +197,18 @@ public R getResult() {
return result;
}
+ @SuppressWarnings("unchecked")
+ public <V> QueryResult<V> swapResult(final V value) {
+ if (isFailure()) {
+ return (QueryResult<V>) this;
Review comment:
> I suppose we could throw an IllegalStateException, since the caller
probably shouldn't be even trying to "swap" the result on a failed result to
begin with, but this seems fine, too.
If there is no strict reason not to throw an `IllegalStateException`, I
would strongly advocate to throw. It's not guards against potential bugs, but
also expressed the semantics for developers (ie, us) much cleaner and make the
code easier to read/reason about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
