florin-akermann commented on a change in pull request #11456:
URL: https://github.com/apache/kafka/pull/11456#discussion_r773067418
##########
File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala
##########
@@ -29,8 +25,16 @@ import kafka.utils.{CommandDefaultOptions, CommandLineUtils,
Exit, ToolsUtils}
import org.apache.kafka.clients.producer.internals.ErrorLoggingCallback
import org.apache.kafka.clients.producer.{KafkaProducer, ProducerConfig,
ProducerRecord}
import org.apache.kafka.common.KafkaException
+import org.apache.kafka.common.header.Header
+import org.apache.kafka.common.header.internals.RecordHeader
Review comment:
@mimaison Hmmm, thanks, isn't it the case that RecordHeader is the only
implementation of Headers?
Or in other words what implementation should I return on line 353?
https://github.com/apache/kafka/pull/11456/files#diff-3b7393aaaffd466b3bfc53c8d95109a206442160b878bbdaa0b0332257afaebaR353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
