[GitHub] [kafka] florin-akermann commented on a change in pull request #11456: KAFKA-13351: Add possibility to write kafka headers in Kafka Console Producer

[GitBox]

florin-akermann commented on a change in pull request #11456:
URL: https://github.com/apache/kafka/pull/11456#discussion_r764457132



##########
File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala
##########
@@ -206,11 +210,25 @@ object ConsoleProducer {
       .describedAs("size")
       .ofType(classOf[java.lang.Integer])
       .defaultsTo(1024*100)
-    val propertyOpt = parser.accepts("property", "A mechanism to pass 
user-defined properties in the form key=value to the message reader. " +
-      "This allows custom configuration for a user-defined message reader. 
Default properties include:\n" +
-      "\tparse.key=true|false\n" +
-      "\tkey.separator=<key.separator>\n" +
-      "\tignore.error=true|false")
+    val propertyOpt = parser.accepts("property",
+      """A mechanism to pass user-defined properties in the form key=value to 
the message reader. This allows custom configuration for a user-defined message 
reader.
+        |Default properties include:
+        | parse.key=false
+        | parse.headers=false
+        | ignore.error=false
+        | key.separator=\t
+        | headers.delimiter=\t
+        | headers.separator=,
+        | headers.key.separator=:
+        |Default parsing pattern when:
+        | parse.headers=true & parse.key=true:

Review comment:
       Now i remember the reason why I chose &
   
![snap](https://user-images.githubusercontent.com/17885538/145125783-ae0e418a-cf2f-4b83-8ba8-d83df3fb9b9e.png)
   
   The lines break in an unfortunate way if 'and' is used. What do you think?
   
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org