ableegoldman commented on a change in pull request #11609:
URL: https://github.com/apache/kafka/pull/11609#discussion_r791123644
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##########
@@ -224,6 +225,7 @@ public void maybeWaitForNonEmptyTopology(final
Supplier<StreamThread.State> thre
} finally {
unlock();
}
+ log.info("Removed NamedTopology {} and updated topology version to
{}", topologyName, version.topologyVersion.get());
Review comment:
There's a semantic difference but it's hard to notice, the first one
says "Remov_ing_" when we start removing it, whereas this one says "Remov_ed_"
to indicate that we have finished. That said it's probably worth clarifying
further, eg `"Finished removing..."` -- I'll update it to make the purpose of
each line more clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
