ableegoldman commented on a change in pull request #11609:
URL: https://github.com/apache/kafka/pull/11609#discussion_r791355579
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java
##########
@@ -319,6 +315,14 @@ private void verifyTopologyStateStore(final String
topologyName, final String st
return streamsMetadataState.getAllMetadataForStore(storeName,
topologyName);
}
+ /**
+ * See {@link KafkaStreams#metadataForAllStreamsClients()}
+ */
+ public Collection<StreamsMetadata>
allStreamsClientsMetadataForTopology(final String topologyName) {
Review comment:
Fair, I was thinking of them as semantically different since for example
in this case we are changing the meaning of the original method to return only
a subset of metadata. Whereas for something like `#store`, I felt it made sense
to keep the same name since the meaning of this API doesn't change when using
named topologies -- you just happen to need one additional parameter in order
to uniquely identify a state store since the name alone could point to multiple
stores from different topologies. But it's definitely something to discuss when
we get to the KIP proposal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
