showuon commented on a change in pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#discussion_r793568939
##########
File path:
core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala
##########
@@ -143,6 +143,7 @@ class AuthorizerIntegrationTest extends BaseRequestTest {
val adminClients = Buffer[Admin]()
producerConfig.setProperty(ProducerConfig.ACKS_CONFIG, "1")
+ producerConfig.setProperty(ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG, "false")
Review comment:
Sorry, I forgot to reply this comment. No we should not remove the
`acks=1` config to enable the idempotence producer. In this
`AuthorizerIntegrationTest` test suite, we tested normal producer (created
here), and IdempotentProducer (created in `buildIdempotentProducer` method),
and transactional producer (created in `buildTransactionalProducer` method), so
if we remove `acks=1` here, we won't be able to test normal producer cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
